Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macauff import pipeline #186

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Macauff import pipeline #186

merged 6 commits into from
Dec 21, 2023

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Dec 8, 2023

Change Description

Implements import pipeline and closes #147.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (b800040) 99.76% compared to head (ff39e53) 99.45%.
Report is 5 commits behind head on main.

Files Patch % Lines
.../hipscat_import/cross_match/macauff_resume_plan.py 95.23% 3 Missing ⚠️
...c/hipscat_import/cross_match/run_macauff_import.py 96.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   99.76%   99.45%   -0.31%     
==========================================
  Files          27       29       +2     
  Lines        1250     1455     +205     
==========================================
+ Hits         1247     1447     +200     
- Misses          3        8       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu changed the title Delucchi/macauff import Macauff import pipeline Dec 14, 2023
@delucchi-cmu delucchi-cmu marked this pull request as ready for review December 14, 2023 19:58
@delucchi-cmu delucchi-cmu merged commit 420e765 into main Dec 21, 2023
11 of 13 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/macauff_import branch December 21, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import pipeline for Macauff association table
2 participants